Add quickselect for impersonated container name, fix CLI env var name (…

…#185)

* Add quickselect for impersonated container name, fix CLI env var name

CHANGELOG.md

@@ -9,6 +9,7 @@ Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how
 ### Added
 - mirrord-cli `exec` subcommand accepts `--extract-path` argument to set the directory to extract the library to. Used for tests mainly.
 - mirrord-layer provides `MIRRORD_IMPERSONATED_CONTAINER_NAME` environment variable to specify container name to impersonate. mirrord-cli accepts argument to set variable.
+- vscode-ext provides quick-select for setting `MIRRORD_IMPERSONATED_CONTAINER_NAME`
 
 ### Changed
 - Refactor e2e, enable only Node HTTP mirroring test.

mirrord-cli/src/config.rs

@@ -60,7 +60,7 @@ pub(super) struct ExecArgs {
 
     /// Select container name to impersonate. Default is first container.
     #[clap(long, value_parser)]
-    pub impersonate_container_name: Option<String>,
+    pub impersonated_container_name: Option<String>,
 
     /// Accept/reject invalid certificates.
     #[clap(short = 'c', long, value_parser)]

mirrord-cli/src/main.rs

@@ -89,10 +89,10 @@ fn exec(args: &ExecArgs) -> Result<()> {
         std::env::set_var("MIRRORD_AGENT_NAMESPACE", namespace.clone());
     }
 
-    if let Some(impersonate_container_name) = &args.impersonate_container_name {
+    if let Some(impersonated_container_name) = &args.impersonated_container_name {
         std::env::set_var(
             "MIRRORD_IMPERSONATED_CONTAINER_NAME",
-            impersonate_container_name,
+            impersonated_container_name,
         );
     }
 

vscode-ext/README.md

@@ -23,3 +23,4 @@ mirrord lets you easily mirror traffic from your Kubernetes cluster to your loca
 
 - You can control the namespace mirrord will find pods by changing the impersonated pod namespace by clicking the settings button next to the Enable/Disable mirrord button
 - You can also control in which k8s namespace the mirrord-agent will spawn using the same setting button.
+- You can control which container to impersonate within the impersonated pod