Fix race condition with container run caused by regression (#2945)

* .. * Fix race condition with container run caused by regression
metalbear-co · Nov 28, 2024 · 4e4adb6 · 4e4adb6
1 parent c7d7f34
commit 4e4adb6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/changelog.d/2944.fixed.md b/changelog.d/2944.fixed.md
@@ -0,0 +1 @@
+Fix race condition with container run caused by regression
diff --git a/mirrord/cli/src/container.rs b/mirrord/cli/src/container.rs
@@ -435,7 +435,9 @@ pub(crate) async fn container_command(
         .status()
         .await;
 
-    let _ = composed_config_file.close();
+    if let Err(err) = composed_config_file.keep() {
+        tracing::warn!(?err, "failed to keep composed config file");
+    }
 
     match runtime_command_result {
         Err(err) => {
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fix race condition with container run caused by regression