Skip to content

Commit

Permalink
PR comments
Browse files Browse the repository at this point in the history
  • Loading branch information
facundopoblete committed Jan 22, 2025
1 parent cd6635b commit 2c274ac
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions mirrord/intproxy/src/proxies/files.rs
Original file line number Diff line number Diff line change
Expand Up @@ -259,24 +259,24 @@ impl FilesProxy {

match request {
FileRequest::ReadLink(..)
if protocol_version.is_some_and(|version| !READLINK_VERSION.matches(version)) =>
if protocol_version.is_none_or(|version| !READLINK_VERSION.matches(version)) =>
{
Err(FileResponse::ReadLink(Err(ResponseError::NotImplemented)))
}
FileRequest::MakeDir(..) | FileRequest::MakeDirAt(..)
if protocol_version.is_some_and(|version| !MKDIR_VERSION.matches(version)) =>
if protocol_version.is_none_or(|version| !MKDIR_VERSION.matches(version)) =>
{
Err(FileResponse::MakeDir(Err(ResponseError::NotImplemented)))
}
FileRequest::RemoveDir(..) | FileRequest::Unlink(..) | FileRequest::UnlinkAt(..)
if protocol_version
.is_some_and(|version: &Version| !RMDIR_VERSION.matches(version)) =>
.is_none_or(|version: &Version| !RMDIR_VERSION.matches(version)) =>
{
Err(FileResponse::RemoveDir(Err(ResponseError::NotImplemented)))
}
FileRequest::StatFs(..)
if protocol_version
.is_some_and(|version: &Version| !STATFS_VERSION.matches(version)) =>
.is_none_or(|version: &Version| !STATFS_VERSION.matches(version)) =>
{
Err(FileResponse::XstatFs(Err(ResponseError::NotImplemented)))
}
Expand Down
2 changes: 1 addition & 1 deletion mirrord/protocol/src/codec.rs
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ pub enum FileRequest {
Access(AccessFileRequest),
Xstat(XstatRequest),
XstatFs(XstatFsRequest),
StatFs(StatFsRequest),
FdOpenDir(FdOpenDirRequest),
ReadDir(ReadDirRequest),
CloseDir(CloseDirRequest),
Expand All @@ -95,6 +94,7 @@ pub enum FileRequest {
RemoveDir(RemoveDirRequest),
Unlink(UnlinkRequest),
UnlinkAt(UnlinkAtRequest),
StatFs(StatFsRequest),
}

/// Minimal mirrord-protocol version that allows `ClientMessage::ReadyForLogs` message.
Expand Down

0 comments on commit 2c274ac

Please sign in to comment.