Skip to content

Commit

Permalink
fix regression in regards to split queues (#2676)
Browse files Browse the repository at this point in the history
* fix regression in regards to split queues

* ..
  • Loading branch information
aviramha authored Aug 18, 2024
1 parent 367ef1c commit 1d4b334
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions changelog.d/2675.fixed.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Make splitqueues optional to support old version
2 changes: 1 addition & 1 deletion mirrord/operator/src/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -739,7 +739,7 @@ impl OperatorApi<PreparedClientCert> {
target,
idle_ttl: Some(Self::COPIED_POD_IDLE_TTL),
scale_down,
split_queues: split_queues.clone(),
split_queues: Some(split_queues.clone()),
},
);

Expand Down
2 changes: 1 addition & 1 deletion mirrord/operator/src/crd.rs
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ pub struct CopyTargetSpec {
/// Ignored if [`Target`] is not [`Target::Deployment`].
pub scale_down: bool,
/// Split queues client side configuration.
pub split_queues: SplitQueuesConfig,
pub split_queues: Option<SplitQueuesConfig>,
}

/// Features and operations that can be blocked by a `MirrordPolicy`.
Expand Down

0 comments on commit 1d4b334

Please sign in to comment.