Skip to content

Commit

Permalink
Fixed towncrier CI
Browse files Browse the repository at this point in the history
  • Loading branch information
Razz4780 committed Oct 1, 2024
1 parent 6e284dd commit 934a218
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 9 deletions.
14 changes: 9 additions & 5 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,22 @@ concurrency:

jobs:
towncrier_check:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Install uv
uses: astral-sh/setup-uv@v2
- run: uv python install
- run: uv venv
- name: install towncrier
run: pip install towncrier==23.11.0
run: uv pip install towncrier==23.11.0
- name: verify newsfragment exist
run: towncrier check
run: uv run towncrier check

lint:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand All @@ -50,7 +54,7 @@ jobs:
# We want this to run even if some of the required jobs got skipped
if: always()
needs: [towncrier_check, e2e, lint]
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- name: CI succeeded
# We have to do it in the shell since if it's in the if condition
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:

jobs:
release:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
Expand Down Expand Up @@ -42,7 +42,7 @@ jobs:

release_gh:
needs: [release]
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
if: github.event_name != 'workflow_dispatch'
permissions:
packages: write
Expand All @@ -67,7 +67,7 @@ jobs:
files: /tmp/release/**

update_latest:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
needs: release_gh
if: github.event_name != 'workflow_dispatch'
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable_e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ on:

jobs:
vscode-e2e:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
env:
CI_BUILD_PLUGIN: "true"
steps:
Expand Down

0 comments on commit 934a218

Please sign in to comment.