Fixed debugger not attaching when running Flask apps (#108)

* Fixed debugger not attaching when running Flask apps * ok gee semicolon ok
metalbear-co · Feb 21, 2024 · 2f8f537 · 2f8f537
1 parent acd761f
commit 2f8f537
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/changelog.d/+fix-attach-python.fixed.md b/changelog.d/+fix-attach-python.fixed.md
@@ -0,0 +1 @@
+Fixed debugger not attaching when running Flask apps
diff --git a/src/debugger.ts b/src/debugger.ts
@@ -77,11 +77,10 @@ async function main(
     return config;
   }
 
+  // Sometimes VSCode launches then attaches, so having a warning/error here is confusing
+  // We used to return null in that case but that failed the attach.
   if (config.request === "attach") {
-    new NotificationBuilder()
-      .withMessage("mirrord cannot be used with `attach` launch configurations")
-      .error();
-    return null;
+    return config;
   }
 
   // For some reason resolveDebugConfiguration runs twice for Node projects. __parentId is populated.
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fixed debugger not attaching when running Flask apps