Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show target selection dialog when there is no config #199

Merged
merged 1 commit into from
Nov 23, 2023
Merged

show target selection dialog when there is no config #199

merged 1 commit into from
Nov 23, 2023

Conversation

t4lz
Copy link
Member

@t4lz t4lz commented Nov 23, 2023

fixed #198

@t4lz t4lz requested a review from Razz4780 November 23, 2023 11:35
@t4lz t4lz force-pushed the fix-target-handling branch from a6b1574 to 0f4d9d7 Compare November 23, 2023 11:36
Razz4780
Razz4780 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@Razz4780 Razz4780 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordConfigAPI.kt Show resolved Hide resolved
@t4lz t4lz added this pull request to the merge queue Nov 23, 2023
Merged via the queue into metalbear-co:main with commit 78cf440 Nov 23, 2023
@t4lz t4lz deleted the fix-target-handling branch November 23, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razz4780 Razz4780 Razz4780 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No target selection dialog when there is no config
2 participants
@t4lz @Razz4780