Fix binary fetch (#94)

* Fixed checking for local binary with the correct version * Changelog entry
metalbear-co · Aug 22, 2023 · f927d45 · f927d45
1 parent 124753d
commit f927d45
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/changelog.d/+binary-fetch.fixed.md b/changelog.d/+binary-fetch.fixed.md
@@ -0,0 +1 @@
+Fixed bug with fetching new mirrord binaries.
diff --git a/modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordBinaryManager.kt b/modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordBinaryManager.kt
@@ -78,9 +78,9 @@ class MirrordBinaryManager {
             manager.latestSupportedVersion = version
 
             val local = if (checkInPath) {
-                manager.getLocalBinary(downloadingVersion, wslDistribution)
+                manager.getLocalBinary(version, wslDistribution)
             } else {
-                manager.findBinaryInStorage(downloadingVersion)
+                manager.findBinaryInStorage(version)
             }
             if (local != null) {
                 return
@@ -99,7 +99,7 @@ class MirrordBinaryManager {
 
             project.service<MirrordProjectService>()
                 .notifier
-                .notifyRichError("failed to update the mirrord binary: ${error.message}")
+                .notifyRichError("failed to update the mirrord binary: ${error.message ?: error.toString()}")
         }
 
         override fun onFinished() {