Fix targetless selection (#200)

* Fixed selecting targetless option in the dialog * Changelog entry * Update changelog.d/+targetless-selection.fixed.md Co-authored-by: t4lz <[email protected]> --------- Co-authored-by: t4lz <[email protected]>
metalbear-co · Nov 23, 2023 · c591745 · c591745
1 parent 78cf440
commit c591745
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/changelog.d/+targetless-selection.fixed.md b/changelog.d/+targetless-selection.fixed.md
@@ -0,0 +1 @@
+Fixed a bug with selecting `targetless` option from the target selection dialog.
diff --git a/modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordExecManager.kt b/modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordExecManager.kt
@@ -7,6 +7,7 @@ import com.intellij.openapi.components.service
 import com.intellij.openapi.progress.ProcessCanceledException
 import com.intellij.openapi.util.SystemInfo
 import com.intellij.openapi.vfs.VirtualFileManager
+import com.intellij.util.alsoIfNull
 import java.nio.file.Path
 
 /**
@@ -135,8 +136,9 @@ class MirrordExecManager(private val service: MirrordProjectService) {
         val target = if (!targetSet) {
             // There is no config file or the config does not specify a target, so show dialog.
             MirrordLogger.logger.debug("target not selected, showing dialog")
-            chooseTarget(cli, wslDistribution, configPath).also {
-                if (it == MirrordExecDialog.targetlessTargetName) {
+            chooseTarget(cli, wslDistribution, configPath)
+                .takeUnless { it == MirrordExecDialog.targetlessTargetName }
+                .alsoIfNull {
                     MirrordLogger.logger.info("No target specified - running targetless")
                     service.notifier.notification(
                         "No target specified, mirrord running targetless.",
@@ -145,7 +147,6 @@ class MirrordExecManager(private val service: MirrordProjectService) {
                         .withDontShowAgain(MirrordSettingsState.NotificationId.RUNNING_TARGETLESS)
                         .fire()
                 }
-            }
         } else {
             null
         }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Fixed a bug with selecting `targetless` option from the target selection dialog.