Fix plugin update check leading to failure (#228)

* Fix plugin update check leading to failure * . * lint
metalbear-co · Jan 5, 2024 · 660e94b · 660e94b
1 parent 25162a8
commit 660e94b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/changelog.d/227.fixed.md b/changelog.d/227.fixed.md
@@ -0,0 +1 @@
+Fix plugin update check leading to failure
diff --git a/modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordExecManager.kt b/modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordExecManager.kt
@@ -110,7 +110,15 @@ class MirrordExecManager(private val service: MirrordProjectService) {
         }
 
         MirrordLogger.logger.debug("version check trigger")
-        service.versionCheck.checkVersion() // TODO makes an HTTP request, move to background
+        try {
+            service.versionCheck.checkVersion() // TODO makes an HTTP request, move to background
+        } catch (e: Throwable) {
+            MirrordLogger.logger.debug("Failed checking plugin updates", e)
+            service.notifier.notifySimple(
+                "Couldn't check for plugin update",
+                NotificationType.WARNING
+            )
+        }
 
         val mirrordApi = service.mirrordApi(projectEnvVars)