Rider 2024.1 fix (#259)

* Removed problematic extension (unused) * Changelog entry
metalbear-co · Apr 17, 2024 · 1e6eced · 1e6eced
1 parent a85b6ef
commit 1e6eced
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 42 deletions.
diff --git a/changelog.d/258.fixed.md b/changelog.d/258.fixed.md
@@ -0,0 +1 @@
+Fixed compatibility with Rider 2024.1
diff --git a/...ider/src/main/kotlin/com/metalbear/mirrord/products/rider/RiderLaunchSettingsExtension.kt b/...ider/src/main/kotlin/com/metalbear/mirrord/products/rider/RiderLaunchSettingsExtension.kt
diff --git a/...er/src/main/kotlin/com/metalbear/mirrord/products/rider/RiderPatchCommandLineExtension.kt b/...er/src/main/kotlin/com/metalbear/mirrord/products/rider/RiderPatchCommandLineExtension.kt
@@ -54,6 +54,10 @@ class RiderPatchCommandLineExtension : PatchCommandLineExtension {
         return resolvedPromise(workerRunInfo)
     }
 
+    /**
+     * This method is the one that overrides in newer Rider versions.
+     */
+    @Suppress("unused", "unused_parameter")
     fun patchDebugCommandLine(
         lifetime: Lifetime,
         workerRunInfo: WorkerRunInfo,

diff --git a/src/main/resources/META-INF/mirrord-rider.xml b/src/main/resources/META-INF/mirrord-rider.xml
@@ -1,6 +1,5 @@
 <idea-plugin>
     <extensions defaultExtensionNs="com.intellij">
         <rider.patchCommandLine implementation="com.metalbear.mirrord.products.rider.RiderPatchCommandLineExtension" />
-        <rider.configurationLaunchSettingsExtension implementation="com.metalbear.mirrord.products.rider.RiderLaunchSettingsExtension" />
     </extensions>
 </idea-plugin>