-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support NIC identifiers as alternative to MAC addresses #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majst01
previously requested changes
Oct 26, 2022
…i into nic-aliases-support
Before merging, we should manually test this PR:
|
…om/metal-stack/metal-api into nic-aliases-support
…o nic-aliases-support
Gerrit91
approved these changes
Feb 20, 2023
This was referenced Feb 23, 2023
Merged
Gerrit91
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is part of implementing support for SONiC.
Currently we are using the mac addresses on the interfaces to calculate machine connections. On SONiC switches though, all mac addresses on the switch interfaces have the same mac address. Therefore, we need some alternative identifier instead of mac addresses in order to support SONiC.
With this PR, metal-core is allowed to alternatively register its interfaces with nic identifiers, which are, if provided, used instead of mac addresses for calculating machine connections.
In order to make the identifiers for SONiC unique across racks, we additionally report
Hostname
with the metal-hammer. When using the identifiers, we can then narrow down nics by the switch hostnames to ensure we only have the corresponding switch nics to be used for calculating the machine connections.The metal-hammer will:
Eth14/4(Port14)
, no mac address<the mac address>
, the mac address as beforeThis is a breaking change for the metal-hammer, it has to be released along with this PR's changes.
/cc @robertvolkmann
References: