libmusicbrainz Visual Studio support#3
Open
Seltzer wants to merge 9 commits into
Open
Conversation
…::WaitRequest() which works in Visual Studio.
… declaration of the following types with includes: - CMedium in MediumList.h - CRelation in RelationList.h - CSecondaryType in SecondaryTypeList.h - CISWC in ISWCList.h * Adding MB_API __declspec macro to defines.h to ensure that musicbrainz5 will export a lib file in VS * Annotating the following with MB_API: - Class declarations which need to be exported - MusicBrainz5::operator << defined in Entity.h * Conditionally excluding the <strings.h> import in mbtest.cc in VS environments
…XMLPARSER_DLL for the musicbrainz5 project when using MSVC generators
…t way until it's tested.
Member
|
I've made a comment on commit 7add92a, not sure if you'll be notified about that so I'm making another comment here. |
* Documenting procedure for libmusicbrainz5 VS solution generation
* Moving MinTimeBetweenRequestsInSeconds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I've tested these changes only in Visual Studio 2010, I've added comments about the risk posed by each (to compilation/operation in other environments).