Skip to content

Demonstrate that rename is broken when CTEs have shadowing #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crisptrutski wants to merge 2 commits into
base: master
Choose a base branch
from
+23 −0
Open

Demonstrate that rename is broken when CTEs have shadowing #121

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a05135
Demonstrate that rename is broken when CTEs have shadowing
crisptrutski Nov 26, 2025
e7b5850
Demonstrate the behaviour better
crisptrutski Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions test/macaw/core_test.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,29 @@ from foo")
:tables {{:schema "public" :table "orders"} "purchases"}
:columns {{:schema "public" :table "orders" :column "x"} "xx"}}))))

(def ^:private cte-before-replace
"WITH z AS (SELECT * FROM a)
SELECT c FROM z")

(def ^:private cte-after-replace
"WITH z AS (SELECT * FROM b)
SELECT c FROM z")

(deftest replace-within-cte-test
(is (= cte-after-replace
(m/replace-names cte-before-replace {:tables {{:table "a"} "b"}})))

(testing "with shadowing"
(let [rr #(str/replace % "z" "a")]
;; TODO fix this, which is broken due to shadowing
(is (= #_(rr cte-after-replace)
;; We treat references to the table `a` as if they were references to the CTE, and therefore leave them.
(rr cte-before-replace)
(m/replace-names (rr cte-before-replace)
{:tables {{:table "a"} "b"}}
{:allow-unused? true}))))))


(deftest allow-unused-test
(is (thrown-with-msg?
Exception #"Unknown rename"
Expand Down