Skip to content

Improve blob-aware approximate size estimates (#15656) #15656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bikash-c wants to merge 1 commit into
base: main
Choose a base branch
from
+1,702 −51
Open

Improve blob-aware approximate size estimates (#15656) #15656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions c_api_gen/c_generated_option_structs_auto.cc.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2271,6 +2271,16 @@ double rocksdb_size_approximation_options_get_files_size_error_margin(
return opt->rep.files_size_error_margin;
}

void rocksdb_size_approximation_options_set_allow_expensive_query(
rocksdb_size_approximation_options_t* opt, unsigned char v) {
opt->rep.allow_expensive_query = v;
}

unsigned char rocksdb_size_approximation_options_get_allow_expensive_query(
rocksdb_size_approximation_options_t* opt) {
return opt->rep.allow_expensive_query;
}

/* LiveFilesStorageInfoOptions */

void rocksdb_livefiles_storage_info_options_set_include_checksum_info(
Expand Down
8 changes: 8 additions & 0 deletions c_api_gen/c_generated_option_structs_auto.h.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -983,6 +983,14 @@ extern ROCKSDB_LIBRARY_API double
rocksdb_size_approximation_options_get_files_size_error_margin(
rocksdb_size_approximation_options_t* opt);

extern ROCKSDB_LIBRARY_API void
rocksdb_size_approximation_options_set_allow_expensive_query(
rocksdb_size_approximation_options_t* opt, unsigned char v);

extern ROCKSDB_LIBRARY_API unsigned char
rocksdb_size_approximation_options_get_allow_expensive_query(
rocksdb_size_approximation_options_t* opt);

/* LiveFilesStorageInfoOptions */

extern ROCKSDB_LIBRARY_API void
Expand Down
6 changes: 6 additions & 0 deletions c_api_gen/c_generated_roundtrip_tests.c.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1111,6 +1111,12 @@ static void rocksdb_roundtrip_test_rocksdb_restore_options(void) {
static void rocksdb_roundtrip_test_rocksdb_size_approximation_options(void) {
rocksdb_size_approximation_options_t* obj =
rocksdb_size_approximation_options_create();
rocksdb_size_approximation_options_set_allow_expensive_query(obj, 1);
CheckCondition(
rocksdb_size_approximation_options_get_allow_expensive_query(obj) == 1);
rocksdb_size_approximation_options_set_allow_expensive_query(obj, 0);
CheckCondition(
rocksdb_size_approximation_options_get_allow_expensive_query(obj) == 0);
rocksdb_size_approximation_options_set_files_size_error_margin(obj, 1);
CheckCondition(
rocksdb_size_approximation_options_get_files_size_error_margin(obj) == 1);
Expand Down
Loading