Skip to content

Check __cpp_lib_unreachable before using std::unreachable in xxhash.h #15655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
r-barnes wants to merge 1 commit into from
+3 −3
Closed

Check __cpp_lib_unreachable before using std::unreachable in xxhash.h #15655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions util/xxhash.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
defined(XXH_IMPLEMENTATION)) && \
!defined(XXH_IMPLEM_13a8737387)
#if defined(__cplusplus) && (__cplusplus > 202002L)
/* C++23 and future versions have std::unreachable() */
#include <utility> /* std::unreachable() */
/* C++23 standard libraries may have std::unreachable() */
#include <utility> /* std::unreachable(), __cpp_lib_unreachable */
#endif
#endif
/* END RocksDB customizations */
Expand Down Expand Up @@ -2072,7 +2072,7 @@ static int XXH_isLittleEndian(void)
# include <stddef.h>
# define XXH_UNREACHABLE() unreachable()

#elif defined(__cplusplus) && (__cplusplus > 202002L)
#elif defined(__cpp_lib_unreachable) && (__cpp_lib_unreachable >= 202202L)
# define XXH_UNREACHABLE() std::unreachable()

#elif XXH_HAS_BUILTIN(__builtin_unreachable)
Expand Down
Loading