Check zch config compability for transfer #3405
Open
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Added a check to validate if zch config is compatible between the source model and the target model. This update is to avoid incorrectly MaaS transfer. For example if the bucket number in the source model is 16 and the number in the target mdoel is 12, even if the zch table size stays the same between these two models, we should apply MPZCH transfer, instead of a noraml transfer, because each row in the source table could map to a different location in the target table. In this update: 1. We added bucket number into state_dict in the checkpoint 2. We compared the bucket numbers between a source model and a target model during transfer. 3. If the bucket number in the source cannot be divided by the number in the target, we raise an exception. Differential Revision: D83580368
meta-cla
bot
added
the
CLA Signed
|
@chaodengusc has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83580368. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added a check to validate if zch config is compatible between the source model and the target model. This update is to avoid incorrectly MaaS transfer.
For example if the bucket number in the source model is 16 and the number in the target mdoel is 12, even if the zch table size stays the same between these two models, we should apply MPZCH transfer, instead of a noraml transfer, because each row in the source table could map to a different location in the target table.
In this update:
Differential Revision: D83580368