Fix Python Flake8 lint error E721. #3402
Closed
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Oct 2, 2025
Summary: Lint error E721 occurs when the type() function is used for type comparison instead of the more flexible isinstance(). The isinstance() function can handle subclasses as well. The codemod only replaces type() function with isinstance() function for type comparison and preserves the existing code functionality while improving code extensibility for future changes. Differential Revision: D83559508
aliafzal
force-pushed
the
export-D83559508
branch
from
78091c5 to
1126e5a
Compare
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Oct 2, 2025
Summary: Lint error E721 occurs when the type() function is used for type comparison instead of the more flexible isinstance(). The isinstance() function can handle subclasses as well. The codemod only replaces type() function with isinstance() function for type comparison and preserves the existing code functionality while improving code extensibility for future changes. Differential Revision: D83559508
aliafzal
force-pushed
the
export-D83559508
branch
from
1126e5a to
08177e2
Compare
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Oct 2, 2025
Summary: Lint error E721 occurs when the type() function is used for type comparison instead of the more flexible isinstance(). The isinstance() function can handle subclasses as well. The codemod only replaces type() function with isinstance() function for type comparison and preserves the existing code functionality while improving code extensibility for future changes. Differential Revision: D83559508
aliafzal
force-pushed
the
export-D83559508
branch
from
08177e2 to
1269187
Compare
Summary: Fixing pre-commit issue caused due to this change D79659949 https://github.com/meta-pytorch/torchrec/actions/runs/18180801024/job/51756057934?fbclid=IwY2xjawNLCBFleHRuA2FlbQIxMQBicmlkETFOR0JqU1h4cVVkOVVpNVlKAR6QCA25THzR5ZdSRoBWwt54TGJvzh9yOoAsOaU1p8ncbWyNnAhrJjfYsQd0_g_aem_d-Vg6liqJiJg8kRY5A8esA Differential Revision: D83727377
Summary: Lint error E721 occurs when the type() function is used for type comparison instead of the more flexible isinstance(). The isinstance() function can handle subclasses as well. The codemod only replaces type() function with isinstance() function for type comparison and preserves the existing code functionality while improving code extensibility for future changes. Differential Revision: D83559508
aliafzal
force-pushed
the
export-D83559508
branch
from
1269187 to
dee9474
Compare
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Oct 2, 2025
Summary: Lint error E721 occurs when the type() function is used for type comparison instead of the more flexible isinstance(). The isinstance() function can handle subclasses as well. The codemod only replaces type() function with isinstance() function for type comparison and preserves the existing code functionality while improving code extensibility for future changes. Differential Revision: D83559508
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Oct 2, 2025
Summary: Lint error E721 occurs when the type() function is used for type comparison instead of the more flexible isinstance(). The isinstance() function can handle subclasses as well. The codemod only replaces type() function with isinstance() function for type comparison and preserves the existing code functionality while improving code extensibility for future changes. Differential Revision: D83559508
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Oct 2, 2025
Summary: Lint error E721 occurs when the type() function is used for type comparison instead of the more flexible isinstance(). The isinstance() function can handle subclasses as well. The codemod only replaces type() function with isinstance() function for type comparison and preserves the existing code functionality while improving code extensibility for future changes. Differential Revision: D83559508
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Oct 2, 2025
Summary: Lint error E721 occurs when the type() function is used for type comparison instead of the more flexible isinstance(). The isinstance() function can handle subclasses as well. The codemod only replaces type() function with isinstance() function for type comparison and preserves the existing code functionality while improving code extensibility for future changes. Differential Revision: D83559508
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Oct 2, 2025
Summary: Lint error E721 occurs when the type() function is used for type comparison instead of the more flexible isinstance(). The isinstance() function can handle subclasses as well. The codemod only replaces type() function with isinstance() function for type comparison and preserves the existing code functionality while improving code extensibility for future changes. Differential Revision: D83559508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Lint error E721 occurs when the type() function is used for type comparison instead of the more flexible isinstance().
The isinstance() function can handle subclasses as well.
The codemod only replaces type() function with isinstance() function for type comparison and preserves
the existing code functionality while improving code extensibility for future changes.
Differential Revision: D83559508