Skip to content

Conversation

@ghyathmoussa
Copy link

@ghyathmoussa ghyathmoussa commented Oct 18, 2025

Pull Request

Description

I have faced some error while using curate functions, after I created a CoT dataset I wanted to curate them but it gives the error below:
✗ Failed to curate Liar_Truth_cot_examples.json: No QA pairs found in the input file
✗ Failed to curate logical-reasoning-2017-12-02_cot_examples.json: No QA pairs found in the input file

I noticed that the created json files do not have a qa_pairs fields

Type of change

I add some logics that control if there is a filed of qa_pairs or cot_examples (for cot paires) so it will combain both the qa and cot pairs in json files.

Please non-releavant options

  • Bug fix (non-breaking change which fixes an issue)
  • [*] New feature (non-breaking change which adds functionality)
  • Breaking change
  • Documentation update

@meta-cla
Copy link

meta-cla bot commented Oct 18, 2025

Hi @ghyathmoussa!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@meta-cla
Copy link

meta-cla bot commented Oct 18, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 18, 2025
@init27
Copy link
Contributor

init27 commented Oct 24, 2025

@ghyathmoussa thanks so much for the PR! Can you please fix the failing tests and then Im happy to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants