Skip to content

fix sharding strategy str to enum conversion #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix sharding strategy str to enum conversion #891

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/llama_cookbook/utils/config_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

import torch.distributed as dist
from torch.distributed.fsdp.fully_sharded_data_parallel import StateDictType
from torch.distributed.fsdp import ShardingStrategy
from torch.utils.data import DistributedSampler
from peft import (
LoraConfig,
Expand Down Expand Up @@ -119,4 +120,6 @@ def check_fsdp_config(fsdp_config):

if not fsdp_config.checkpoint_type in VALID_TYPES:
raise ValueError(f"Invalid checkpoint_type {fsdp_config.checkpoint_type}")


if isinstance(fsdp_config.sharding_strategy, str):
fsdp_config.sharding_strategy=ShardingStrategy[fsdp_config.sharding_strategy]
Loading