Skip to content

refactor: Rename fromZeros to isFromZeroAddress in Lido.ts for better semantics #2686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: Rename fromZeros to isFromZeroAddress in Lido.ts for better semantics #2686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions subgraphs/lido/src/mappings/Lido.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@ export function handleTransfer(event: Transfer): void {
getOrCreateToken(Address.fromString(ETH_ADDRESS), event.block.number);
getOrCreateToken(Address.fromString(PROTOCOL_ID), event.block.number);

const fromZeros = sender == Address.fromString(ZERO_ADDRESS);
const isFromZeroAddress = sender == Address.fromString(ZERO_ADDRESS);
const isMintToTreasury =
fromZeros && recipient == Address.fromString(PROTOCOL_TREASURY_ID);
isFromZeroAddress && recipient == Address.fromString(PROTOCOL_TREASURY_ID);
let isMintToNodeOperators = false;

// get node operators
Expand All @@ -114,7 +114,7 @@ export function handleTransfer(event: Transfer): void {
}

isMintToNodeOperators =
fromZeros &&
isFromZeroAddress &&
((nodeOperators.includes(recipient) as boolean) ||
recipient == Address.fromString(PROTOCOL_NODE_OPERATORS_REGISTRY_ID));

Expand All @@ -131,7 +131,7 @@ export function handleETHDistributed(event: ETHDistributed): void {
return;
}

// Don’t mint/distribute any protocol fee on the non-profitable Lido oracle report
// Don't mint/distribute any protocol fee on the non-profitable Lido oracle report
// (when beacon chain balance delta is zero or negative).
// See ADR #3 for details: https://research.lido.fi/t/rewards-distribution-after-the-merge-architecture-decision-record/1535
const postCLTotalBalance = event.params.postCLBalance.plus(
Expand Down