Load sprintf.js via npm

[swissspidy]

This requires the sprintf.js npm module instead of inlining it and updates the library from 0.7-beta1 to version 1.0.3. A few changes to the tests were required to accommodate for the change.

See #41.

[SlexAxton]

Hmm. The two reasons I inline sprintf in the past were because of the undefined behavior here, and because it wasn't on npm at the time I wrote this :).

Would love to not have to change this undefined behavior, it's never what people want.

[swissspidy]

What do you think about throwing an error instead of just turning undefined into an empty string? I think it would be better to make people aware of their errors instead of suppressing them.

I'd be happy to add support for this to the sprintf library if that sounds good to you.

[SlexAxton]

Is it really an error to have empty values? I think runtime errors in
translation are never more helpful than just outputting empty strings. I'd
be ok with adding a hook to be notified of these problems, but just
erroring out and not rendering someone's text seems like an extreme
punishment for a missing variable.
On Fri, Sep 23, 2016 at 1:34 PM Pascal Birchler [email protected]
wrote:

What do you think about throwing an error instead of just turning
undefined into an empty string? I think it would be better to make people
aware of their errors instead of suppressing them.

I'd be happy to add support for this to the sprintf library if that sounds
good to you.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#46 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAF5Kl2ZgnIK5EybJWz9x_WcTHunsG1Cks5qtBvCgaJpZM4KE7s0
.

[swissspidy]

@SlexAxton Just stumbled upon this again. What do you think about using the latest version of sprintf from npm (see also #56) and then wrap a little helper function around them to handle undefined? Happy to submit a PR.

[SlexAxton]

Happy to take a PR for that.

…

On Fri, Aug 10, 2018 at 1:36 AM Pascal Birchler ***@***.***> wrote: @SlexAxton <https://github.com/SlexAxton> Just stumbled upon this again. What do you think about using the latest version of sprintf from npm (see also #56 <#56>) and then wrap a little helper function around them to handle undefined? Happy to submit a PR. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#46 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAF5Km0csLK_t3uHpEUmNk1XGXlYF7qsks5uPSntgaJpZM4KE7s0> .