new lookup endpoints: non-null first param of read() fails because it can be null on the parent method

Marcel Corso · Marcel Corso · commit 3159933d1e8a · 2015-12-16T16:38:16.000+01:00
diff --git a/src/MessageBird/Resources/Lookup.php b/src/MessageBird/Resources/Lookup.php
@@ -34,7 +34,7 @@ public function __construct(Common\HttpClient $HttpClient)
      * @throws \MessageBird\Exceptions\RequestException
      * @throws \MessageBird\Exceptions\ServerException
      */
-    public function read($phoneNumber, $countryCode = null)
+    public function read($phoneNumber = null, $countryCode = null)
     {
         if(empty($phoneNumber)) {
             throw new InvalidArgumentException('The phone number cannot be empty.');
diff --git a/src/MessageBird/Resources/LookupHLR.php b/src/MessageBird/Resources/LookupHLR.php
@@ -58,7 +58,7 @@ public function create($hlr, $countryCode = null)
      * @throws \MessageBird\Exceptions\RequestException
      * @throws \MessageBird\Exceptions\ServerException
      */
-    public function read($phoneNumber, $countryCode = null)
+    public function read($phoneNumber = null, $countryCode = null)
     {
         if(empty($phoneNumber)) {
             throw new InvalidArgumentException('The phone number cannot be empty.');

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public function __construct(Common\HttpClient $HttpClient)`
`34`	`34`	`* @throws \MessageBird\Exceptions\RequestException`
`35`	`35`	`* @throws \MessageBird\Exceptions\ServerException`
`36`	`36`	`*/`
`37`		`- public function read($phoneNumber, $countryCode = null)`
	`37`	`+ public function read($phoneNumber = null, $countryCode = null)`
`38`	`38`	`{`
`39`	`39`	`if(empty($phoneNumber)) {`
`40`	`40`	`throw new InvalidArgumentException('The phone number cannot be empty.');`
Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ public function create($hlr, $countryCode = null)`
`58`	`58`	`* @throws \MessageBird\Exceptions\RequestException`
`59`	`59`	`* @throws \MessageBird\Exceptions\ServerException`
`60`	`60`	`*/`
`61`		`- public function read($phoneNumber, $countryCode = null)`
	`61`	`+ public function read($phoneNumber = null, $countryCode = null)`
`62`	`62`	`{`
`63`	`63`	`if(empty($phoneNumber)) {`
`64`	`64`	`throw new InvalidArgumentException('The phone number cannot be empty.');`