new lookup endpoints: prevent user to call methods without a phone number

Author: Marcel Corso

examples/lookup-view.php

@@ -10,7 +10,6 @@
 
     $Lookup = $MessageBird->lookup->read("624971134", "NL");
     var_dump($Lookup);
-
 } catch (\MessageBird\Exceptions\AuthenticateException $e) {
     // That means that your accessKey is unknown
     echo 'wrong login';

src/MessageBird/Resources/Lookup.php

@@ -4,6 +4,7 @@
 
 use MessageBird\Objects;
 use MessageBird\Common;
+use InvalidArgumentException;
 
 /**
  * Class Verify
@@ -33,8 +34,11 @@ public function __construct(Common\HttpClient $HttpClient)
      * @throws \MessageBird\Exceptions\RequestException
      * @throws \MessageBird\Exceptions\ServerException
      */
-    public function read($phoneNumber = null, $countryCode = null)
+    public function read($phoneNumber, $countryCode = null)
     {
+        if(empty($phoneNumber)) {
+            throw new InvalidArgumentException('The phone number cannot be empty.');
+        }
         $query = null; 
         if ($countryCode != null) {
             $query = array("countryCode" => $countryCode);

src/MessageBird/Resources/LookupHLR.php

@@ -4,6 +4,7 @@
 
 use MessageBird\Objects;
 use MessageBird\Common;
+use InvalidArgumentException;
 
 /**
  * Class LookupHLR 
@@ -35,6 +36,10 @@ public function __construct(Common\HttpClient $HttpClient)
      */
     public function create($hlr, $countryCode = null)
     {
+        if(empty($hlr->msisdn)) {
+            throw new InvalidArgumentException('The phone number ($hlr->msisdn) cannot be empty.');
+        }
+
         $query = null;
         if ($countryCode != null) {
             $query = array("countryCode" => $countryCode);
@@ -53,8 +58,12 @@ public function create($hlr, $countryCode = null)
      * @throws \MessageBird\Exceptions\RequestException
      * @throws \MessageBird\Exceptions\ServerException
      */
-    public function read($phoneNumber = null, $countryCode = null)
+    public function read($phoneNumber, $countryCode = null)
     {
+        if(empty($phoneNumber)) {
+            throw new InvalidArgumentException('The phone number cannot be empty.');
+        }
+
         $query = null;
         if ($countryCode != null) {
             $query = array("countryCode" => $countryCode);

tests/integration/lookup/LookupTest.php

@@ -16,6 +16,14 @@ public function testReadLookup()
         $this->client->lookup->read(31612345678);
     }
 
+    /**
+     * @expectedException InvalidArgumentException
+     */
+    public function testReadLookupWithEmptyNumber()
+    {
+        $this->client->lookup->read(null);
+    }
+
     /**
      * @expectedException     MessageBird\Exceptions\ServerException
        */
@@ -40,6 +48,16 @@ public function testCreateLookupHLR()
         $this->client->lookupHLR->create($Hlr);
     }
 
+    /**
+     * @expectedException InvalidArgumentException
+     */
+    public function testCreateLookupHLRWithEmptyNumber()
+    {
+        $Hlr             = new \MessageBird\Objects\Hlr();
+        $Hlr->msisdn     = null;
+        $this->client->lookupHLR->create($Hlr);
+    }
+
     /**
      * @expectedException     MessageBird\Exceptions\ServerException
        */
@@ -65,6 +83,14 @@ public function testReadLookupHLR()
         $this->client->lookupHLR->read(31612345678);
     }
 
+    /**
+     * @expectedException InvalidArgumentException
+     */
+    public function testReadLookupHLRWithEmptyNumber()
+    {
+        $this->client->lookupHLR->read(null);
+    }
+
     /**
      * @expectedException     MessageBird\Exceptions\ServerException
        */