Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource allocation-related fixes, etc #93

Merged
merged 3 commits into from
Feb 20, 2016
Merged

resource allocation-related fixes, etc #93

merged 3 commits into from
Feb 20, 2016

Conversation

jdef
Copy link
Contributor

@jdef jdef commented Feb 20, 2016

  • fixes scheduler should property allocate driver-port for etcd-mesos-executor #92: properly allocate libprocess port for executor driver
  • fix resource allocation to take into account executor resources
  • executor should attempt to use LIBPROCESS_IP as binding address for compat on multihomed hosts
  • don't launch the executor in shell mode: it's a simple command w/ a simple set of args
  • fix some govet and make test errors

fixes #92: properly allocate libprocess port for executor driver; fix…
f877bb3 
… resource allocation to take into account executor resources; executor should attempt to use LIBPROCESS_IP as binding address for compat on multihomed hosts
@jdef jdef added the WIP label Feb 20, 2016
@jdef jdef changed the title resource allocation-related fixes resource allocation-related fixes, etc Feb 20, 2016
@jdef
Copy link
Contributor Author

jdef commented Feb 20, 2016

/cc @spacejam PTAL

@spacejam
Copy link
Contributor

LGTM! Feel free to merge at your convenience

jdef
jdef reviewed Feb 20, 2016
View reviewed changes
cmd/etcd-mesos-executor/app.go
if libprocessIP := os.Getenv("LIBPROCESS_IP"); libprocessIP != "" {
address = net.ParseIP(libprocessIP)
if address == nil {
log.Warning("failed to parse IP address from LIBPROCESS_IP envvar %q", libprocessIP)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Warning/Warningf/

jdef added a commit that referenced this pull request Feb 20, 2016
@jdef
Merge pull request #93 from mesosphere/jdef_fix_92
791feed 
resource allocation-related fixes, etc
@jdef jdef merged commit 791feed into master Feb 20, 2016
@jdef jdef deleted the jdef_fix_92 branch February 20, 2016 01:14
@jdef jdef removed the WIP label Feb 20, 2016
@jdef jdef mentioned this pull request Feb 20, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scheduler should property allocate driver-port for etcd-mesos-executor
2 participants
@jdef @spacejam