Skip to content

Conversation

@mochaaP
Copy link
Contributor

@mochaaP mochaaP commented Dec 1, 2025

@mochaaP mochaaP force-pushed the mochaa/msft_proxy4-4.0.1 branch 4 times, most recently from 5773776 to 98ec8d3 Compare December 1, 2025 19:57
Copy link
Collaborator

@bgilbert bgilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting Meson support upstream. In WrapDB, though, wraps must point to upstream releases. This wrap not only points to an untagged commit hash, it's a commit in an unmerged PR, with no indication that upstream intends to actually merge it. That won't work: we need to be able to maintain the Meson config downstream in WrapDB until upstream takes responsibility for maintaining it as part of a release.

If the purpose of this PR is to test the code in WrapDB's CI, that's fine, but please mention that clearly in the PR and mark it as draft. Otherwise, you'll need to point the .wrap to the most recent official release and copy the Meson files into a patch_directory in the PR.

@mochaaP mochaaP marked this pull request as draft December 1, 2025 21:05
@mochaaP
Copy link
Contributor Author

mochaaP commented Dec 1, 2025

marking as draft until merged upstream.

@mochaaP mochaaP force-pushed the mochaa/msft_proxy4-4.0.1 branch 16 times, most recently from a20c358 to 1a2ecf6 Compare December 3, 2025 08:45
@mochaaP mochaaP force-pushed the mochaa/msft_proxy4-4.0.1 branch from 1a2ecf6 to a763811 Compare December 6, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants