vo-aacenc.wrap: Fix building as a subproject #2425
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CI fails due to mesonbuild/meson#15062. Can be re-run when 1.9.2 or newer versions are released. |
Due to the header layout, this was previously only usable after installation into a prefix.
This comment was marked as resolved.
This comment was marked as resolved.
bgilbert
reviewed
Dec 11, 2025
nirbheek
force-pushed
the
voaacenc
branch
2 times, most recently
from
113a8eb to
4864a2d
Compare
AssertionError: Found files subprojects/packagefiles/vo-aacenc/meson/makedef.py with license headers in a project without a LICENSE.build. The LICENSE.build file in the patch ZIP defaults to MIT unless the patch directory has its own LICENSE.build, which should state the license for the wrap's build files.
On armv7, we use a feature introduced in '1.2.0': compiler.compiles with file created at setup time. It was broken and either errored or returned false.
Member
Author
|
Will merge in a week if there are no objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the header layout, this was previously only usable after installation into a prefix.