-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Set version, soversion from cmake if available
#14682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set version, soversion from cmake if available
#14682
Conversation
Maybe because setting version/soversion changes the output file name? |
|
I added that This is only because I don't see a way to get a version from a target object, if there's a nicer way I'd love to use that 😁 |
|
Changed the test case assertion to be dependent on the host system. Interestingly I also found that on Windows-Cygwin |
03aaf8c to
331d9de
Compare
|
I just squashed the fixups, should be good to go now! 🙂 |
|
This still looks good to me, I've added it the milestone for the next release so we can get it in once the merge window opens. |
|
Merge window is open, in it goes. |
|
This breaks with static libraries that export Many projects support being built as both shared or static library and I guess that very few filter out their target properties based on the library type. |
|
The fix is in #15297. |
This is a pretty basic thing that we should be pulling in from cmake