Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: adding isolated build test #209

Merged
merged 1 commit into from
Nov 17, 2022
Merged

TST: adding isolated build test #209

merged 1 commit into from
Nov 17, 2022
+81 −1

Conversation

henryiii
Copy link
Contributor

Pulled out of 175.

@henryiii henryiii force-pushed the henryiii/ci/isolatedtest branch from c9110c1 to e1bb59e Compare November 16, 2022 20:06
@henryiii
Copy link
Contributor Author

Is there a better test than scipy-like? I think part of the problem is that this is getting an SDist of something that needs to build (with setuptools, you can see it trying to get setuptools on Cygwin), like maybe NumPy or something.

@henryiii henryiii added the tests label Nov 16, 2022
@dnicolodi
Copy link
Member

scipy-like requires Cython to build. As you cannot use the published wheel for Cython and Cython uses setuptools as build system, you need to get setuptools too. IIRC I already expressed dubs regarding choosing this particular test package. purelib-and-platlib may be a better choice.

dnicolodi
dnicolodi reviewed Nov 16, 2022
View reviewed changes
@henryiii henryiii force-pushed the henryiii/ci/isolatedtest branch 2 times, most recently from 0d71ceb to 00ea85a Compare November 16, 2022 22:53
henryiii
henryiii commented Nov 16, 2022
View reviewed changes
tests/test_pep518.py
@pytest.mark.parametrize(
'build_arg', ['', '--wheel'], ids=['sdist_to_wheel', 'wheel_directly']
)
@pytest.mark.xfail(sys.platform.startswith('cygwin'), reason='ninja pip package not available on cygwin', strict=True)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this fails on Cygwin in this branch (no ninja package), and passes in #175 - it's great to see this test does exactly what is supposed to do! :)

@henryiii
Copy link
Contributor Author

You added build to the extra-requires and it is sufficient.

Not for Sage CI, actually. Hopefully I fixed it by adding python-build.

@henryiii
Copy link
Contributor Author

meson dist is still broken. It's building meson-python successfully from SDist, it's just trying to make this package (I'm guessing outside of a git repo) and breaking. Is there a way to use meson dist outside a git repo? Actually, I bet in_git_repo_context() has something to do with it. I'll look into it tomorrow.

@henryiii
TST: adding isolated build test
07ad119 
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/ci/isolatedtest branch from 00ea85a to 07ad119 Compare November 17, 2022 05:49
@FFY00 FFY00 merged commit 5f47941 into mesonbuild:main Nov 17, 2022
@eli-schwartz
Copy link
Member

Is there a way to use meson dist outside a git repo?

No, because meson dist internally runs git archive, plus additional handling for subprojects (which either use git and are treated the same, or else don't use git and are copied entirely on the assumption that subprojects/*/ is effectively read-only).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnicolodi dnicolodi

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@henryiii @dnicolodi @eli-schwartz @FFY00