Skip to content

Fix #715 - Change chatId validation schema #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025

Conversation

philon-
Copy link
Contributor

@philon- philon- commented Jul 21, 2025

Description

This PR changes the validation schema for the routing input chatId, allowing all id's from 0 to 4294967294 (0xffffffff - 1).

Related Issues

Fixes #715

Changes Made

  • Updated the Zod validation schema

Testing Done

Screenshots (if applicable)

Checklist

  • Code follows project style guidelines
  • Documentation has been updated or added
  • Tests have been added or updated
  • All i18n translation labels have been added (read
    CONTRIBUTING_I18N_DEVELOPER_GUIDE.md for more details)

@Copilot Copilot AI review requested due to automatic review settings July 21, 2025 22:07
Copy link

vercel bot commented Jul 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web-test ✅ Ready (Inspect) Visit Preview Jul 21, 2025 10:08pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the chatId validation schema to allow a broader range of valid chat IDs, changing from specific channel/node ID ranges to accepting any integer from 0 to 4294967294 (0xffffffff - 1). This addresses issue #715 by simplifying the validation logic and expanding the accepted ID range.

Key changes:

  • Removed restrictive chatId validation schema that only allowed channel IDs (0-10) or node IDs (1000000000-9999999999)
  • Replaced with inline validation accepting all integers from 0 to 4294967294
  • Updated Zod import to version 4

@danditomaso danditomaso merged commit afb7f4b into meshtastic:main Jul 22, 2025
3 checks passed
@philon- philon- deleted the fix-715-channel-id-validation branch July 22, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: (client-test) Client crashes when selecting a node from the messages list that uses rak4631 hardware
2 participants