Skip to content

fix: Skip meshery-integration-template model during registry generate #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ontiomacer wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix: Skip meshery-integration-template model during registry generate #839

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
748011a
fix: Skip meshery-integration-template model during registry generate
Ontiomacer Nov 26, 2025
0d45d91
refractor: use constant for template model name
Ontiomacer Nov 26, 2025
9472104
refractor: use constant for template model name
Ontiomacer Nov 26, 2025
9680422
refractor: use PublishToRegistry flag to filter models
Ontiomacer Dec 3, 2025
4762578
Fix: Removing unused const delaration
Ontiomacer Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions registry/model.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
package registry

import (
"bytes"
"context"
Expand Down Expand Up @@ -32,7 +31,7 @@ import (
"golang.org/x/sync/semaphore"
"google.golang.org/api/sheets/v4"
)

const mesheryIntegrationTemplateModel = "meshery-integration-template"
Copy link
Member

@leecalcote leecalcote Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed and goes against the objective of being "anti-brittle".

var modelToCompGenerateTracker = store.NewGenericThreadSafeStore[compGenerateTracker]()

type compGenerateTracker struct {
Expand Down Expand Up @@ -837,11 +836,19 @@ func InvokeGenerationFromSheet(wg *sync.WaitGroup, path string, modelsheetID, co
}
}()
// Iterate models from the spreadsheet
for _, model := range modelCSVHelper.Models {

if modelName != "" && modelName != model.Model {
continue
}
for _, model := range modelCSVHelper.Models
{
if modelName != "" && modelName != model.Model
{
continue
}

if modelName == "" && strings.ToLower(strings.TrimSpace(model.PublishToRegistry)) != "true"
{
log.Infof("Skipping model: %s (PublishToRegistry != true)", model.Model)
continue
}
}
totalAvailableModels++
ctx := context.Background()

Expand Down