Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Inline Styles from card.html to SCSS #1870

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Move Inline Styles from card.html to SCSS #1870

wants to merge 2 commits into from

Conversation

rohitsrma
Copy link

Description

This PR fixes a part of #896

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@netlify Netlify
Copy link

netlify bot commented Aug 15, 2024 •
edited
Loading

✅ Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 17ef407
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/66be659ad6a68d0008d61496
😎 Deploy Preview https://deploy-preview-1870--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rohitsrma rohitsrma force-pushed the move-inline-styles-from-card branch from 6179a93 to 30934fe Compare August 15, 2024 14:54
@rohitsrma rohitsrma changed the title Move Inline Styles from card.html to CSS Move Inline Styles from card.html to SCSS Aug 15, 2024
leecalcote
leecalcote reviewed Aug 15, 2024
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rohitsrma. 👍 Does this impact the https://meshery.io/extensions cards, too?

@rohitsrma
Copy link
Author

@leecalcote It had not, but now I have made the change.

@Ashparshp
Copy link

@rohitsrma, Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@stale Stale
Copy link

stale bot commented Sep 21, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Sep 21, 2024
@stale Stale
Copy link

stale bot commented Sep 30, 2024

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

@stale stale bot closed this Sep 30, 2024
@Ashparshp Ashparshp added issue/willfix This issue will be worked on issue/remind Issue progress check and removed issue/stale Issue has not had any activity for an extended period of time labels Sep 30, 2024
@github-actions GitHub Actions
Copy link

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.

        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@github-actions github-actions bot reopened this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/website issue/remind Issue progress check issue/willfix This issue will be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohitsrma @Ashparshp @leecalcote