Merge develop into main
#321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #283. Towards #189. This PR adds a new `Field` class, which becomes fundamental to pretty much the whole setup. It contains mesh-independent metadata: * Name * Finite element * Solved for? * Unsteady? With this, we replace `TimePartition.field_names` with `TimePartition.fields`. Also, `TimePartition.field_types` gets absorbed into the `Field.unsteady` bool. Since the finite element is set in the `Field`, there's no longer any need to pass `get_function_spaces` to `MeshSeq` - these can be deduced from the `Field`. (Current WIP). Currently, we continue to have multiple fields associated with a single time partition, so that the API doesn't change much. However, in the future we can support having multiple time partitions associated with different fields, for the case where different fields have different time discretisations. --------- Co-authored-by: Davor Dundovic <[email protected]> Also contains: Drop get_function_spaces (#296) Introduce get_element and get_function_space methods to Field class (#301)
Partial rework of #292. Towards #289. Following the recent addition of the `Field` class, this PR accounts for its `solved_for` attribute. `Field`s that are not solved for can be skipped in the adjoint solver. Unit tests are included. --------- Co-authored-by: Davor Dundovic <[email protected]>
Closes #316. This was removed in firedrakeproject/firedrake#4499. This PR also picks up hotfixes from #315 that were merged into `main`, not `develop`. mesh-adaptation/animate#201 will need to be merged first. --------- Co-authored-by: Davor Dundovic <[email protected]>
This PR adds a `CODEOWNERS` file so that the codeowners mentioned will automatically be added as reviewers for any PR that gets opened. This is useful because external contributors can't request reviewers. I also took the opportunity to update the maintainers list.
stephankramer
approved these changes
Nov 19, 2025
Collaborator
stephankramer
left a comment
stephankramer
left a comment
There was a problem hiding this comment.
Makes sense. Tbh I'm a bit too far removed, and you're much more qualified to say if this is stable. If there's particular bits you want me to look at in more detail let me know, but I think this is good to go.
github-project-automation
bot
moved this from Ready for review
to Done
in Mesh Adaptation development board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering why the Goalie in the Docker image was still out of date (and failing in mesh-adaptation/docs#161) and the reason why is that we've patched
developbut notmain.I think this is a good opportunity to align them and then move to
mainandreleaseinstead.