Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'YYYY-MM-DD' as gantt default date format #6163

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

good-jinu
Copy link

@good-jinu good-jinu commented Jan 3, 2025

📑 Summary

The Gantt chart diagram type documentation claims that "The default input date format is YYYY-MM-DD."

See document

However in actuality, an explicit dateFormay YYYY-MM-DD must be given for such dates to be recognized.

Resolves #5862 , #5655

📏 Design Decisions

I set default date format as "YYYY-MM-DD"

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Jan 3, 2025

🦋 Changeset detected

Latest commit: a8dfc66

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Jan 3, 2025
Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit a8dfc66
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/6777ddc0e72e3e000870351e
😎 Deploy Preview https://deploy-preview-6163--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@good-jinu good-jinu changed the title Set 'YYYY-MM-DD' as gantt default date format fix: 'YYYY-MM-DD' as gantt default date format Jan 3, 2025
Copy link

pkg-pr-new bot commented Jan 3, 2025

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6163
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6163
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6163
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6163

commit: a8dfc66

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.48%. Comparing base (df636c6) to head (a8dfc66).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6163   +/-   ##
=======================================
  Coverage     4.48%   4.48%           
=======================================
  Files          383     382    -1     
  Lines        54038   54027   -11     
  Branches       596     621   +25     
=======================================
  Hits          2425    2425           
+ Misses       51613   51602   -11     
Flag Coverage Δ
unit 4.48% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/diagrams/gantt/ganttDb.js 77.47% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link

argos-ci bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 339 added, 339 removed, 4 failures Jan 3, 2025, 1:02 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mermaid Gantt - specifying <end date> in this pattern <taskID>, after <otherTaskId>, <endDate>
1 participant