Skip to content

run spotless formatting on QueryStringMapper #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niteshsandal-merge merged 1 commit into from
Aug 28, 2025
Merged

run spotless formatting on QueryStringMapper #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/main/java/com/merge/api/core/QueryStringMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ public class QueryStringMapper {

public static void addQueryParameter(HttpUrl.Builder httpUrl, String key, Object value, boolean arraysAsRepeats) {
JsonNode valueNode = MAPPER.valueToTree(value);

// In cases where valueNode is a list of strings, we want to return a comma separated string
if (key.equals("expand")) {
String commaSeparatedQueryParams = "";

if (valueNode.isArray()) {
List<String> values = new ArrayList<>();
for (JsonNode node : valueNode) {
Expand All @@ -35,7 +35,8 @@ public static void addQueryParameter(HttpUrl.Builder httpUrl, String key, Object
} else if (value instanceof String) {
String text = ((String) value).trim();
if (text.startsWith("[") && text.endsWith("]")) {
commaSeparatedQueryParams = text.replace("[", "").replace("]", "").replace(", ", ",");
commaSeparatedQueryParams =
text.replace("[", "").replace("]", "").replace(", ", ",");
}
}

Expand All @@ -44,7 +45,7 @@ public static void addQueryParameter(HttpUrl.Builder httpUrl, String key, Object
return;
}
}

List<Map.Entry<String, JsonNode>> flat;
if (valueNode.isObject()) {
flat = flattenObject((ObjectNode) valueNode, arraysAsRepeats);
Expand All @@ -58,7 +59,7 @@ public static void addQueryParameter(HttpUrl.Builder httpUrl, String key, Object
}
return;
}

for (Map.Entry<String, JsonNode> field : flat) {
if (field.getValue().isTextual()) {
httpUrl.addQueryParameter(key + field.getKey(), field.getValue().textValue());
Expand Down