Update addQueryParameter to handle a list of strings
#78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran into an unexpected issue while reviewing this PR. Please try again later. |
fern-support
commented
May 23, 2025
Comment on lines
+25
to
+46
| // In cases where valueNode is a list of strings, we want to return a comma separated string | ||
| if (key.equals("expand")) { | ||
| String commaSeparatedQueryParams = ""; | ||
|
|
||
| if (valueNode.isArray()) { | ||
| List<String> values = new ArrayList<>(); | ||
| for (JsonNode node : valueNode) { | ||
| values.add(node.asText()); | ||
| } | ||
| commaSeparatedQueryParams = String.join(",", values); | ||
| } else if (value instanceof String) { | ||
| String text = ((String) value).trim(); | ||
| if (text.startsWith("[") && text.endsWith("]")) { | ||
| commaSeparatedQueryParams = text.replace("[", "").replace("]", "").replace(", ", ","); | ||
| } | ||
| } | ||
|
|
||
| if (commaSeparatedQueryParams.length() > 0) { | ||
| httpUrl.addQueryParameter(key, commaSeparatedQueryParams); | ||
| return; | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're updating Merge's code so that users can pass a list of strings as query parameters. The logic in this PR will convert the list of strings to a comma separated string of all the query parameters.