Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Updated pr-check ci job to prevent unused 'test' job #209

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

Andrew718PLTS
Copy link
Contributor

@Andrew718PLTS Andrew718PLTS commented Mar 14, 2025

Description

There was a test job that was remaining even after the unit-tests job is completed (it's been renamed to unit-tests in previous PR). Here I just renamed it back to test.

Other changes

None

Tested

An explanation of how the changes were tested or an explanation as to why they don't need to be.

Related issues

  • Fixes #issue number here

Checklist before requesting a review

@Copilot Copilot bot review requested due to automatic review settings March 14, 2025 12:58
Copy link

vercel bot commented Mar 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mento-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 0:59am

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI workflow configuration by renaming a job to address an unused 'test' job issue.

  • Job renamed from "unit-tests" to "test"
  • Updated workflow file to reflect the new job naming
Comments suppressed due to low confidence (1)

.github/workflows/pr-check.yml:97

  • [nitpick] The new job name 'test' is ambiguous; if this job specifically runs unit tests, consider using a more descriptive name such as 'unit-tests' to avoid confusion.
test:
@Andrew718PLTS Andrew718PLTS changed the title Fix: Updated pr-check ci job to prevent unused 'test' job #2 Fix: Updated pr-check ci job to prevent unused 'test' job Mar 14, 2025
Copy link
Contributor

@chapati23 chapati23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, all checks passing again

@chapati23 chapati23 merged commit c7763b1 into main Mar 17, 2025
8 checks passed
@chapati23 chapati23 deleted the fix/unused-test-ci-job branch March 17, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants