Fix several issues related to processing of malformed ELF files #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I've been doing some fuzzing recently, and found several issues related to processing malformed ELF files. Those are pretty much all out-of-bound reads, which mostly lead to crashes.
I've written several fixes for these. Where possible, I improve existing bounds checks, so "slightly" broken ELFs still can be loaded. In other places, I throw std::runtime_error() to avoid segfault.
I also added some missing includes, so the app compiles with more modern compilers.
I've also noticed that tests (elfparser-cli-ng_test) are broken. They are already broken on current master branch, so it's not caused by me changes. I'm not sure how to best fix those, so I just left them as-is.