Set TrackAlias in SUBSCRIBE_OK (draft-13 fix)#266
Open
paulharter wants to merge 1 commit intomengelbart:mainfrom
Open
Set TrackAlias in SUBSCRIBE_OK (draft-13 fix)#266paulharter wants to merge 1 commit intomengelbart:mainfrom
paulharter wants to merge 1 commit intomengelbart:mainfrom
Conversation
The draft-13 message format update (92fd720) moved TrackAlias assignment from the subscriber (in SUBSCRIBE) to the publisher (in SUBSCRIBE_OK). The localTrack correctly receives a publisher-assigned alias via s.trackAliases.next(), but acceptSubscriptionWithOptions did not copy lt.trackAlias into the outgoing SubscribeOkMessage. This left TrackAlias at its zero value for every SUBSCRIBE_OK, preventing subscribers from correctly dispatching incoming datagrams by alias. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The draft-13 message format update (92fd720) moved TrackAlias assignment from the subscriber (in SUBSCRIBE) to the publisher (in SUBSCRIBE_OK). The
localTrackcorrectly receives a publisher-assigned alias vias.trackAliases.next(), butacceptSubscriptionWithOptionsdid not copylt.trackAliasinto the outgoingSubscribeOkMessage. This leftTrackAliasat its zero value (0) for every SUBSCRIBE_OK, preventing subscribers from correctly dispatching incoming datagrams by alias.Change
One line in
session.go: use thelocalTrackreturned byconfirm()and setTrackAlias: lt.trackAliasin theSubscribeOkMessage.Test plan
go test ./...)