[WC-2902] Move caption error to warning#1545
Merged
Conversation
r0b1n
changed the title
gjulivan
previously approved these changes
Apr 24, 2025
r0b1n
force-pushed
the
wc-2902-caption-required
branch
from
7ef599a to
d34c477
Compare
r0b1n
force-pushed
the
wc-2902-caption-required
branch
from
d34c477 to
c522a84
Compare
… empty While this check is still helpful, this check might go wrong in a scenario with multiple languages involved. Prevent this check from showstopping app from running by switching this check to a warning. Also fix warnings in tests
r0b1n
force-pushed
the
wc-2902-caption-required
branch
from
c522a84 to
9eb8af5
Compare
leonardomendix
approved these changes
May 13, 2025
gjulivan
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
While this check is still helpful, this check might go wrong in a scenario with
multiple languages involved. Prevent this check from showstopping app from
running by switching this check to a warning.
Also fix warnings in tests.