[WC-2882] Use text input for number filter #1533
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0b1n
changed the title
r0b1n
changed the title
|
@HedwigAR changing type=number to type=text because javascript is not good with numbers. |
r0b1n
force-pushed
the
wc-2882/fix-number-parsing
branch
4 times, most recently
from
7201bf7 to
1047bc6
Compare
iobuhov
approved these changes
Apr 17, 2025
r0b1n
force-pushed
the
wc-2882/fix-number-parsing
branch
from
5d425f4 to
f347761
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Input of type=number is having build it behavior for number parsing, this messes up with locale-specific number parsing, switch to type=text.
Bonus: highlight the input in red when number parsing was not successful.