-
Notifications
You must be signed in to change notification settings - Fork 3
[Draft] Atlas 4 #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Draft] Atlas 4 #26
Conversation
- introduce calculated shades (e.g. var(--brand-primary-90) etc.) - introduce theming structure - replace SASS variable usages in Atlas
- for backwards compatibility with modules which may still be using SASS variables and have no defaults set in the project
- new sidebar layout - minor tweaks
f0b912d
to
50ad691
Compare
- added sidebar layout - added sidebar menu structure for content (WIP) - UI refresh: - page templates - dashboard action center - change layouts of widget pages - convert to 10.18 - add dark-theme stylesheet (for future) - minor styling tweaks
- Page wide gutter size - Container: Border radius, Card, Display type - Button: Style - Layout grid: Cards style, Background color, Column gap, Row gap, Border radius
50ad691
to
b025066
Compare
In the developer experience side, are we also going to add any of the ideas that we had regarding the top and menu bar configuration? https://mendix.atlassian.net/wiki/spaces/FD/pages/3353968716/Layouts+-+Atlas+default+and+TopBar |
@@ -81,61 +81,62 @@ | |||
// When used in sidebar | |||
.region-sidebar { | |||
.mx-navigationtree { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TEST: check if this background removal affect anything.
@@ -16,7 +16,7 @@ | |||
padding: 0; | |||
/* Clear search button (overrides load more button stying) */ | |||
& > ul { | |||
margin: 0 0 $spacing-medium; | |||
margin: 0 0 var(--gutter-size); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--spacing-small
continue here https://github.com/mendix/atlas/pull/195/files |
@if $use-legacy-variables { | ||
/*== Gray Shades*/ | ||
/*## Different gray shades to be used for our variables and components */ | ||
--gray-darker: #{$gray-darker}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will make the application not able to compile,
because the variables are use inside "if - use legacy vars - scope,
while the declaration of the vars are outside on another "else" considition.
a5fc050
to
035be84
Compare
035be84
to
84cc627
Compare
Upgraded to the split MPR format (v2) Upgrade to 10.21 Update Atlas Core
WIP PR for Atlas 4
Done
In progress
Todo's