Skip to content

[Draft] Atlas 4 #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

[Draft] Atlas 4 #26

wants to merge 38 commits into from

Conversation

takumagott
Copy link
Contributor

@takumagott takumagott commented Jan 23, 2025

WIP PR for Atlas 4

Done

  • Replace SASS variables with CSS variables
  • Generated color shades

In progress

  • Updated look (new theme)
  • New design properties
  • Introduce sidebar layout
  • Updated page templates
  • Updated building blocks
  • Docs

Todo's

  • Review design properties from ES
  • Forms layout
  • Update other widgets / modules to use CSS variables
  • Figure out the best way to support modules still using SASS variables
  • Test accessibility
  • Test responsiveness
  • Rebase onto main
  • Requires releasing Atlas Core, Atlas Web Content, and all modules which transitioned to CSS variables (e.g. data widgets)
  • Update starter app

- introduce calculated shades (e.g. var(--brand-primary-90) etc.)
- introduce theming structure
- replace SASS variable usages in Atlas
- for backwards compatibility with modules which may still be using SASS variables and have no defaults set in the project
- new sidebar layout
- minor tweaks
@takumagott takumagott force-pushed the ui-refresh branch 4 times, most recently from f0b912d to 50ad691 Compare January 23, 2025 21:16
- added sidebar layout
- added sidebar menu structure for content (WIP)
- UI refresh:
  - page templates
  - dashboard action center
- change layouts of widget pages
- convert to 10.18
- add dark-theme stylesheet (for future)
- minor styling tweaks
- Page wide gutter size
- Container: Border radius, Card, Display type
- Button: Style
- Layout grid: Cards style, Background color, Column gap, Row gap, Border radius
@Catoledo84
Copy link
Contributor

In the developer experience side, are we also going to add any of the ideas that we had regarding the top and menu bar configuration? https://mendix.atlassian.net/wiki/spaces/FD/pages/3353968716/Layouts+-+Atlas+default+and+TopBar

@@ -81,61 +81,62 @@
// When used in sidebar
.region-sidebar {
.mx-navigationtree {
Copy link
Contributor

@gjulivan gjulivan Feb 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TEST: check if this background removal affect anything.

@@ -16,7 +16,7 @@
padding: 0;
/* Clear search button (overrides load more button stying) */
& > ul {
margin: 0 0 $spacing-medium;
margin: 0 0 var(--gutter-size);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--spacing-small

@gjulivan
Copy link
Contributor

@if $use-legacy-variables {
/*== Gray Shades*/
/*## Different gray shades to be used for our variables and components */
--gray-darker: #{$gray-darker};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will make the application not able to compile,
because the variables are use inside "if - use legacy vars - scope,
while the declaration of the vars are outside on another "else" considition.

@takumagott takumagott force-pushed the ui-refresh branch 2 times, most recently from a5fc050 to 035be84 Compare February 26, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants