Add method to allow retrieval of listener tag during pool configuration #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dormando
reviewed
Apr 22, 2025
| return id | ||
| end | ||
| } | ||
| ctx._listen_tag = tag |
There was a problem hiding this comment.
is this code missing something? I don't see where tag is coming from.
There was a problem hiding this comment.
Sorry -- missed a couple lines when I was copying over. I'll fix it now
|
Could use a test. Looks like the best idea is a new test file with some |
FinnitoProductions
force-pushed
the
patch-3
branch
from
6babbd6 to
8f88b7b
Compare
|
Sure @dormando, I'll tackle it by EOD! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for a route to retrieve its associated listener tag. This enables us to use the same route across multiple different listeners, and for it to execute execute custom configuration behavior depending on its associated listener.