Include demos in docs #1013
Open
Include demos in docs #1013
+69
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-hek
reviewed
Oct 30, 2025
mix.exs
Outdated
Comment on lines
138
to
139
| {first_letter, rest} = | ||
| filename |
There was a problem hiding this comment.
I missed this previously, but you can use String.capitalize instead
There was a problem hiding this comment.
I can't, since this will change acronyms like RTSP to Rtsp, I tried
There was a problem hiding this comment.
The docs for String.capitalize say you should use :string.titlecase in that case :P
Comment on lines
+121
to
+129
| demo_title = | ||
| demo_path | ||
| |> Path.join("README.md") | ||
| |> File.read!() | ||
| |> String.split("\n") | ||
| |> List.first() | ||
| |> String.trim_leading("#") | ||
| |> String.trim_leading() | ||
| |> String.to_atom() |
There was a problem hiding this comment.
Couldn't we generate the title based on the directory where the demo lives?
There was a problem hiding this comment.
Not really, the directory names in our repo are not nice, changing them would probably break the links in a lot of places + they're all lowercase
There was a problem hiding this comment.
Ok, then I'd use a regex to get the markdown title, but this can be too
mat-hek
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.