Add WHIP support #49
Open
Add WHIP support #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelonEkonom
reviewed
Dec 2, 2024
lib/boombox.ex
Outdated
Comment on lines
152
to
155
| if Keyword.keyword?(opts) do | ||
| opts = parse_whip_opts(opts) | ||
| {:webrtc, {:whip, opts}} | ||
| end |
There was a problem hiding this comment.
I guess we should raise if Keyword.keyword?/1 returns false
There was a problem hiding this comment.
FelonEkonom
reviewed
Jan 3, 2025
There was a problem hiding this comment.
Please ensure that Browser -> MP4 livebook example works with WHIP and membrane_webrtc_plugin from this branch: membraneframework/membrane_webrtc_plugin#15
If WHIP doesn't spoil anything it should be fine
| @@ -9,7 +9,7 @@ System.put_env("PATH", "/opt/homebrew/bin:#{System.get_env("PATH")}") | |||
| # In case of problems installing Nx/EXLA/Bumblebee, | |||
| # you can remove them and the Nx backend config below. | |||
| # Examples that don't mention them should still work. | |||
| Mix.install([:boombox, :kino, :nx, :exla, :bumblebee, :websockex, :membrane_simple_rtsp_server]) | |||
| Mix.install([{:boombox, path: "/Users/matheksm/m/boombox"}, :kino, :nx, :exla, :bumblebee, :websockex]) | |||
There was a problem hiding this comment.
it doesn't work on my computer :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #26