Skip to content

Commit

Permalink
Fix bug #9179: OMERO-cpp.bat fails on notification
Browse files Browse the repository at this point in the history
Removing the "shell" argument from the Popen call removes the [Errno 22]
error. A check has been also added in "communicate()" to return when run
on Windows platforms, as an early exit from the function.
  • Loading branch information
Blazej Pindelski committed Sep 7, 2012
1 parent cb0454e commit dbda952
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions build.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,11 @@

def popen(args, stdin=None, stdout=subprocess.PIPE, stderr=subprocess.PIPE):
copy = os.environ.copy()
shell = (sys.platform == "win32")
return subprocess.Popen(args,
env=copy,
stdin=stdin,
stdout=stdout,
stderr=stderr,
shell=shell)
stderr=stderr)


def execute(args):
Expand All @@ -40,7 +38,7 @@ def notification(msg, prio):
"""

# May want to revert this to be OMERO_BUILD_NOTIFICATION, or whatever.
if "OMERO_QUIET" in os.environ:
if "OMERO_QUIET" in os.environ or sys.platform == "win32":
return

try:
Expand Down

0 comments on commit dbda952

Please sign in to comment.