Fix/benchmark runnable baseline - #25
Merged
Merged
Conversation
Contributor
|
Good Job! LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR restores a supported, reproducible, and unbiased smoke/baseline path for the existing benchmark suite.
It addresses the six confirmed benchmark issues:
128k,500k,1m, and10mscales to their actual upstream Hugging Face sourcesChanges
Benchmark entrypoints
benchmark/aml-local/retrieve.py.run_aml_local.ps1to use the supported orchestrator.BEAM dataset mapping
Added explicit mappings for:
128k→Mohammadta/BEAM, split100K500k→Mohammadta/BEAM, split500K1m→Mohammadta/BEAM, split1M10m→Mohammadta/BEAM-10M, split10MThe bundled
sampleconversion remains fully offline.Resume behavior
--resumenow reuses every successfully completed and judged result, whether correct or incorrect.--no-resumeperforms a fresh run.Preflight and run metadata
Preflight now checks the required dataset, daemon, credentials, Python dependencies, parameters, and writable output paths before ingestion or paid provider calls.
Run manifests record the code revision, dataset identity, model identities, retrieval configuration, resume mode, timestamps, wall-clock duration, and available token usage. Missing provider usage is represented as unavailable rather than a fabricated zero.
CI and documentation
Added an offline benchmark smoke job covering:
--helpUpdated the benchmark documentation to match the supported commands, data sources, resume semantics, and the distinction between internal TypeScript evaluation, AML-compatible local evaluation, and hosted AML leaderboard evaluation.
Validation
pnpm install --frozen-lockfile--helpchecks passed without credentialsScope
This PR does not:
top_k, or scoring methodsFixture, mock, typecheck, and smoke results are not presented as evidence that the full paid benchmarks have been executed.
Closes #24