Skip to content

Conversation

kumarUjjawal
Copy link
Contributor

@kumarUjjawal kumarUjjawal commented Sep 22, 2025

Pull Request

This PR aims to bring the SDK close to the Mealisearch Meilisearch 1.19 features and add support for sharding .

Related issue

Fixes #700

What does this PR do?

As per the tasks described in the origina issue #700

  • Update the Network methods to accept sending the sharding parameter

  • Update the Network methods to include remotes.[remoteName].writeApiKey in the responses

  • Update the Tasks methods to include remotes objects in the tasks reponse index update method to allow renaming

  • Add new test cases to test implementation

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Copy link

codecov bot commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 82.69231% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.91%. Comparing base (e1bfc99) to head (ca562a0).

Files with missing lines Patch % Lines
src/client.rs 75.00% 16 Missing ⚠️
src/tasks.rs 94.87% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #709      +/-   ##
==========================================
- Coverage   85.96%   85.91%   -0.06%     
==========================================
  Files          19       19              
  Lines        5950     6054     +104     
==========================================
+ Hits         5115     5201      +86     
- Misses        835      853      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.19.0] Add sharding support
1 participant