-
Notifications
You must be signed in to change notification settings - Fork 91
Remove README.md
API section, refactor Documentation section
#1866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1866 +/- ##
=======================================
Coverage 99.03% 99.03%
=======================================
Files 18 18
Lines 1449 1449
Branches 305 305
=======================================
Hits 1435 1435
Misses 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I agree this is causing unnecessary maintenance. However, I think the users are mostly facing these issues because the |
WalkthroughThe README.md file was updated to remove the detailed "API resources" section, which previously listed TypeScript method signatures and links for Meilisearch client API operations. This section was replaced with two succinct documentation links, and the table of contents was updated to reflect this change. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
I have addressed this in #1948 |
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
43-47
: Optional: Improve bullet styling for consistency
For consistency with other title-cased headings in the README, you could capitalize the link text and description and swap the Unicode “─” for an em-dash:- [client library documentation](https://meilisearch.github.io/meilisearch-js/modules.html) ─ information on each exported item of this package + [Client library documentation](https://meilisearch.github.io/meilisearch-js/modules.html) — Information on each exported item of this package - [main documentation website](https://www.meilisearch.com/docs/) ─ general - information on how to use Meilisearch—such as our API reference, tutorials, - guides, and in-depth articles + [Main documentation website](https://www.meilisearch.com/docs/) — General information on how to use Meilisearch, including our API reference, tutorials, guides, and in-depth articles
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
README.md
(1 hunks)
🔇 Additional comments (2)
README.md (2)
43-44
: Validate client library documentation link
The new[client library documentation]
link correctly points to the generated modules page and succinctly replaces the old in-README API listings.
45-47
: Validate main documentation website link
The[main documentation website]
link now directs users to the centralized docs site for full API references, tutorials, and guides—this is a clear and maintainable replacement for the removed API section.
Pull Request
What does this PR do?
README.md
API sectionPR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!
Summary by CodeRabbit