Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: Don't overwrite object ID in geosearch response #1314

Merged
merged 5 commits into from
Sep 16, 2024
Merged

🐛 fix: Don't overwrite object ID in geosearch response #1314

merged 5 commits into from
Sep 16, 2024

Conversation

queer
Copy link
Contributor

@queer queer commented Aug 4, 2024

Pull Request

Related issue

Fixes #1308.

What does this PR do?

This avoids overwriting the objectID field if it is already present. This allows code that depends on the objectID returned by Meilisearch to function, while still adding it for data sets that don't have it.

This also updates CONTRIBUTING.md to have the right command for the geosearch playground.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Copy link

changeset-bot bot commented Aug 4, 2024

🦋 Changeset detected

Latest commit: fa02104

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@meilisearch/instant-meilisearch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@curquiza curquiza requested a review from flevi29 August 5, 2024 08:40
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @queer

Sorryf for the delay

Can you add tests to ensure the change is well applied?

@curquiza curquiza added the bug Something isn't working label Aug 7, 2024
@curquiza
Copy link
Member

curquiza commented Aug 7, 2024

Also can you run yarn changeset? More information in our CONTRIBUTING steps
Make is as a patch release

Copy link
Collaborator

@flevi29 flevi29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flevi29 flevi29 requested a review from curquiza August 27, 2024 09:28
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

bors merge

@meili-bors meili-bors bot merged commit 871b675 into meilisearch:main Sep 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

instant-meilisearch geosearch overwrites objectID
4 participants