-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix: Don't overwrite object ID in geosearch response #1314
🐛 fix: Don't overwrite object ID in geosearch response #1314
Conversation
🦋 Changeset detectedLatest commit: fa02104 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also can you run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
bors merge
Pull Request
Related issue
Fixes #1308.
What does this PR do?
This avoids overwriting the
objectID
field if it is already present. This allows code that depends on theobjectID
returned by Meilisearch to function, while still adding it for data sets that don't have it.This also updates
CONTRIBUTING.md
to have the right command for the geosearch playground.PR checklist
Please check if your PR fulfills the following requirements: